rearrange_dim and delete_pass bug fixes #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The original check didn't account for the case where the permutation is longer than N, but contains all the numbers between 0 and N-1.
* We have previously used the external pattern matching API to implement delete_pass which throws an error when matches aren't found. * Now, we use the internal pattern matching which simply returns an empty list.
|
@skeqiqevian should review this |
yamaguchi1024
pushed a commit
that referenced
this pull request
Apr 24, 2024
- delete_pass is a no-op when there are no passes.
* We have previously used the external pattern matching API to implement
delete_pass which throws an error when matches aren't found.
* Now, we use the internal pattern matching which simply returns an empty list.
- Fix bug in rearrange_dim value checking.
* The original check didn't account for the case where the list
contains all the numbers between 0 and N-1, but is longer than N.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete_pass which throws an error when matches aren't found.
empty list.
contains all the numbers between 0 and N-1, but is longer than N.