Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot of stdlib and rewrite gemm #583

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Conversation

SamirDroubi
Copy link
Collaborator

sgemm_aspect_ratio
sgemm_square

@@ -132,7 +108,8 @@ def make_bottom_panel_kernel_scheduled(p=bottom_panel_kernel):
p = rename(p, "bottom_panel_kernel_scheduled")
p = specialize(p, "for k in _: _ #0", [f"M == {i}" for i in range(1, M_REG_BLK)])
p = simplify(p)
for M in range(1, 6):
dce(p)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p = dce(p)?

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 54.82055% with 642 lines in your changes are missing coverage. Please review.

Project coverage is 85.65%. Comparing base (b343217) to head (5540f46).

Files Patch % Lines
src/exo/stdlib/stdlib.py 45.57% 461 Missing ⚠️
src/exo/stdlib/inspection.py 59.71% 143 Missing ⚠️
src/exo/stdlib/rc_wrappers.py 75.86% 28 Missing ⚠️
src/exo/stdlib/higher_order.py 77.77% 10 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   88.23%   85.65%   -2.58%     
==========================================
  Files          83       87       +4     
  Lines       19747    20995    +1248     
==========================================
+ Hits        17423    17983     +560     
- Misses       2324     3012     +688     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SamirDroubi
Copy link
Collaborator Author

It seems like the sgemm schedule is hanging for some reason. Let's not merge this until we figure out why.

@SamirDroubi SamirDroubi merged commit 34dbeca into main Mar 6, 2024
7 checks passed
@SamirDroubi SamirDroubi deleted the stdlib-snapshot-rewrite-gemm branch March 6, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants