Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sink_alloc
is roughly the inverse operation oflift_alloc
. However,sink_alloc
andlift_alloc
are incorrect as it stands. The plan is to come back and fix the issue (described below) when we have rewritten analysis.In writing this scheduling operation, I noticed an analysis error in
lift_alloc
. However, fixing this analysis requires data dependent analysis.Consider the following:
These programs are not equivalent because of the cross-iteration read/write dependencies. However, the current
lift_alloc
lacks analysis to reason about this and permits this transformation.