Normalize abd range analysis bug fix #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When merging a binop range, range analysis was implicitly assuming that those ranges are completely independent i.e. the expression contains only one read of each symbol that occurs in the expression. This is now an explicit check. Moreover, _DoNormalize had a related bug where we were calling range analysis on the Seq hi expression before nornalizing it. Finally, there was an unrelated bug, which this commit fixes, were the symbols ranges environment in _DorNormalize wasn't being properly setup in if/else statement.
yamaguchi1024
approved these changes
Apr 28, 2023
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #421 +/- ##
==========================================
- Coverage 86.63% 86.60% -0.03%
==========================================
Files 76 76
Lines 17544 17556 +12
==========================================
+ Hits 15199 15205 +6
- Misses 2345 2351 +6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.