-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support arguments ordering in extract_subproc #409
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #409 +/- ##
==========================================
+ Coverage 86.48% 86.50% +0.01%
==========================================
Files 76 76
Lines 17542 17564 +22
==========================================
+ Hits 15171 15193 +22
Misses 2371 2371
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, just some minor comments. Feel free to adjust or not
src/exo/LoopIR_scheduling.py
Outdated
for i in range(len(arg_list)): | ||
if arg_list[i].name.name() == key: | ||
new_args[order[key]] = arg_list[i] | ||
if any(a == 0 for a in new_args): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can merge the two errors if you just check that sorted(order.values()) == [0, 1, ..., len(arg_list) -1]?
y: R[8] @ DRAM | ||
for j in seq(0, 8): | ||
x = 0.0 | ||
fooooo(y, x, j)def fooooo(y: R[8], x: R, j: index): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a new line here lol
No description provided.