Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forwarding bug + API Cursors bug #391

Merged
merged 4 commits into from
Apr 9, 2023
Merged

Forwarding bug + API Cursors bug #391

merged 4 commits into from
Apr 9, 2023

Conversation

SamirDroubi
Copy link
Collaborator

This PR fixes two unrelated bugs:
1- Bug in forwarding same as #388
2- Missing import in API_cursors

@SamirDroubi SamirDroubi marked this pull request as ready for review April 9, 2023 20:48
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2023

Codecov Report

Merging #391 (9d4f364) into master (b193279) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   86.74%   86.69%   -0.05%     
==========================================
  Files          76       76              
  Lines       17189    17202      +13     
==========================================
+ Hits        14910    14914       +4     
- Misses       2279     2288       +9     
Impacted Files Coverage Δ
src/exo/API_cursors.py 74.18% <ø> (ø)
src/exo/internal_cursors.py 95.77% <100.00%> (+0.04%) ⬆️
tests/test_cursors.py 98.50% <100.00%> (+0.23%) ⬆️

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@SamirDroubi SamirDroubi enabled auto-merge (squash) April 9, 2023 21:26
@SamirDroubi SamirDroubi merged commit 7a06638 into master Apr 9, 2023
@SamirDroubi SamirDroubi deleted the forwarding-bug branch April 9, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants