Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forwarding composition in divide_dim #375

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Fix forwarding composition in divide_dim #375

merged 1 commit into from
Apr 4, 2023

Conversation

alexreinking
Copy link
Contributor

Forwarding functions weren't being composed... I should have caught this in review.

@yamaguchi1024 yamaguchi1024 enabled auto-merge (squash) April 4, 2023 17:46
@yamaguchi1024 yamaguchi1024 merged commit aa04d9a into master Apr 4, 2023
@yamaguchi1024 yamaguchi1024 deleted the fix-divide-dim branch April 4, 2023 17:48
@skeqiqevian
Copy link
Collaborator

I'm not sure this is right. _replace_pats updates the fwd function and returns the updated version, so there's no need for additional composition?

@alexreinking
Copy link
Contributor Author

I'm not sure this is right. _replace_pats updates the fwd function and returns the updated version, so there's no need for additional composition?

That's right, and was fixed in #376 -- the issue is that _replace_pats_stmts didn't apply the forwarding function internally. Or rather, things were type-incorrect and the function signatures were inconsistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamaguchi1024 yamaguchi1024 yamaguchi1024 approved these changes

@skeqiqevian skeqiqevian Awaiting requested review from skeqiqevian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexreinking @skeqiqevian @yamaguchi1024