Implement internal node-cursor forwarding #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 86.30% 86.25% -0.05%
==========================================
Files 73 73
Lines 16487 16537 +50
==========================================
+ Hits 14229 14264 +35
- Misses 2258 2273 +15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yamaguchi1024
approved these changes
Jan 30, 2023
There was a problem hiding this comment.
LGTM if it's ready to merge. Can #278 be closed because of this?
Yes. This is a better implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements node-only forwarding for internal cursors over the following edit operations:
The implementation of move is complicated. Unexpectedly so. I've tried to write useful tests for all of these, but we might still encounter bugs. We need to stay diligent about adding test cases for bugs we fix.
Closes #278