Fix const-window argument passing #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
commented
Nov 12, 2022
| @@ -66,8 +70,8 @@ struct exo_win_2i8c{ | |||
| const int8_t * const data; | |||
| const int_fast32_t strides[2]; | |||
| }; | |||
| struct exo_win_3i8c{ | |||
| const int8_t * const data; | |||
| struct exo_win_3i8{ | |||
There was a problem hiding this comment.
In this test and the others, these structs aren't actually used anywhere. I'm guessing they come from instr signatures, but I'm not totally sure.
There was a problem hiding this comment.
Just curious, was there any warning or performance consequence from not having const?
There was a problem hiding this comment.
Nothing we rigorously measured. But there are still a great many reasons for having const.
- Having
constenables the C compiler to check our generated code. If we misplace a const the C compiler will warn or error, and that means our analysis somewhere is wrong. This helps us catch bugs. - Having accurate
constinformation makes it easier to integrate into existing C codebases. For instance, someone might have a const-qualified buffer in their program. They would have to cast away that const to call an Exo function. That's a recipe for unexpected / undefined behavior.
and so on...
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
=======================================
Coverage 87.91% 87.92%
=======================================
Files 72 72
Lines 15632 15652 +20
=======================================
+ Hits 13743 13762 +19
- Misses 1889 1890 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered at the Hackathon yesterday. We don't have enough tests that stress parameter passing, which is why this wasn't caught in the first place...