Fmla support added #285
Merged
Fmla support added #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @adcastel , thanks for the PR! |
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
==========================================
+ Coverage 86.28% 86.30% +0.01%
==========================================
Files 73 73
Lines 16386 16416 +30
==========================================
+ Hits 14139 14168 +29
- Misses 2247 2248 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
yamaguchi1024
requested changes
Nov 14, 2022
|
Vfmla test added |
yamaguchi1024
requested changes
Dec 16, 2022
tests/test_neon.py
Outdated
| @@ -83,7 +83,53 @@ def simple_math_neon(n: size, x: R[n] @ DRAM, y: R[n] @ DRAM): # pragma: no cov | |||
| fn(None, n, x, y) | |||
| assert np.allclose(x, expected) | |||
|
|
|||
| #@pytest.fixture | |||
There was a problem hiding this comment.
Suggested change
| #@pytest.fixture | |
| @pytest.mark.isa("neon") |
tests/test_neon.py
Outdated
|
|
||
| p = test_neon_vfmla() | ||
| print(p) |
There was a problem hiding this comment.
Suggested change
| print(p) |
tests/test_neon.py
Outdated
|
|
||
| p = test_neon_vfmla() |
There was a problem hiding this comment.
Suggested change
| p = test_neon_vfmla() |
tests/test_neon.py
Outdated
| p = autofission(p, p.find('B_vec[_] = _').after(), n_lifts=2) | ||
| p = replace(p, 'for l in _: _ #0', neon_vld_4xf32) | ||
| p = set_memory(p, 'B_vec', Neon4f) | ||
| print(p) |
There was a problem hiding this comment.
Suggested change
| print(p) |
auto-merge was automatically disabled
December 29, 2022 14:32
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the support for fmla neon assembly instruction
It works with microkernel generation.
I can show the resulting code in the next meeting.