Add can_read to memories #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI this is coming from Adrian's email |
|
I think the problem is with this line: Line 95 in 6e7419e Should be |
|
@alexreinking The line is fine, it's trying to say that whoever inherits this class should specify if the memory is readable or not, which I think is fair. |
alexreinking
requested changes
Nov 3, 2022
tests/test_neon.py
Outdated
|
|
||
| import numpy as np | ||
|
|
||
|
|
||
| @pytest.mark.isa("neon") |
There was a problem hiding this comment.
This test doesn't actually run anything on NEON, it just needs to get as far as generating C. Therefore it should never be skipped and you can check that read_neon.c_code_str() throws the expected MemGenError.
alexreinking
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea why we didn't discover this until now...