Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate PatternParser #255

Merged
merged 5 commits into from
Oct 24, 2022
Merged

Deprecate PatternParser #255

merged 5 commits into from
Oct 24, 2022

Conversation

yamaguchi1024
Copy link
Member

@yamaguchi1024 yamaguchi1024 commented Oct 24, 2022 •
edited
Loading

This PR unifies PatternParser to Parser class

Fixes #249

@yamaguchi1024 yamaguchi1024 changed the title deprecate PatternParser Deprecate PatternParser Oct 24, 2022
alexreinking
alexreinking requested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Just for the sake of maintenance, I'd like the self.AST change applied throughout.

src/exo/pyparser.py Outdated Show resolved Hide resolved
src/exo/pyparser.py Outdated Show resolved Hide resolved
src/exo/pyparser.py Show resolved Hide resolved
alexreinking
alexreinking requested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last little Python "gotcha".

src/exo/pyparser.py Outdated Show resolved Hide resolved
src/exo/pyparser.py Outdated Show resolved Hide resolved
alexreinking
alexreinking approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@yamaguchi1024 yamaguchi1024 enabled auto-merge (squash) October 24, 2022 17:58
@yamaguchi1024 yamaguchi1024 merged commit 98edc6b into master Oct 24, 2022
@yamaguchi1024 yamaguchi1024 deleted the merge_parser branch October 24, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexreinking alexreinking alexreinking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework parser to have the same path for proc and fragment
2 participants
@yamaguchi1024 @alexreinking