Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind expr fix #254

Merged
merged 12 commits into from
Oct 24, 2022
Merged

Bind expr fix #254

merged 12 commits into from
Oct 24, 2022

Conversation

skeqiqevian
Copy link
Collaborator

@skeqiqevian skeqiqevian commented Oct 21, 2022

CSE no longer replaces the LHS, and will only replace the RHS until it encounters a read to any buffer that the expression depends on.

Fixes #238

Copy link
Contributor

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another small fix.

src/exo/LoopIR_scheduling.py Outdated Show resolved Hide resolved
src/exo/LoopIR_scheduling.py Outdated Show resolved Hide resolved
@yamaguchi1024 yamaguchi1024 enabled auto-merge (squash) October 24, 2022 02:47
Copy link
Contributor

@alexreinking alexreinking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@yamaguchi1024 yamaguchi1024 merged commit 32c6413 into master Oct 24, 2022
@yamaguchi1024 yamaguchi1024 deleted the bind_expr_fix branch October 24, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bind_expr with CSE is broken
3 participants