Codegen cleanup #240
Merged
Codegen cleanup #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
force-pushed
the
codegen/const-correctness
branch
from
43a8e09
to
e82e079
Compare
alexreinking
force-pushed
the
codegen/const-correctness
branch
from
e82e079
to
1866905
Compare
| @@ -396,7 +392,7 @@ gemmini_extended_compute_preloaded((uint32_t)(&*(int8_t*)((uint64_t)( ((uint32_t | |||
| } | |||
| } | |||
| if (orow_ii + 7 * orow_io == 0 || false) { | |||
| gemmini_extended4_config_ld(((struct exo_win_2i8){ (int8_t*)&inp[(b) * (58 * 58 * 64) + (1 + orow_ii + 7 * orow_io + 28 * orow_o) * (58 * 64) + (2 + 16 * ocol_o) * (64) + (0) * (1)], { 64, 1 } }).strides[0]*1, 1.0f, 0, (16), 2); | |||
| gemmini_extended4_config_ld(((struct exo_win_2i8c){ &inp[(b) * (58 * 58 * 64) + (1 + orow_ii + 7 * orow_io + 28 * orow_o) * (58 * 64) + (2 + 16 * ocol_o) * (64) + (0) * (1)], { 64, 1 } }).strides[0]*1, 1.0f, 0, (16), 2); | |||
|
Great changes!! |
|
Not yet. That will be my next PR or two |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
constto function signaturesWhen a function does not write or accumulate to a parameter it's passed, it should tell the C compiler about this by declaring it
const. In some cases that can promote inlining or better codegen and definitely improves the ergonomics of using exo functions by allowing callers to declare their local variables const in the first place. It also plays nicer with C's type system generally.Use
voidinstead of an empty structThis prevents an actual ABI issue whereby a C compiler is allowed to give such a struct a size of 0, but C++ must give it a size of 1.
Fixes #95
Only generate
_floor_divand_clamp_32to8when needed.Self-explanatory. Also uses
exo_prefixes since leading underscores are generally sketchy in C.