Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement commute() #224

Merged
merged 4 commits into from
Sep 8, 2022
Merged

Implement commute() #224

merged 4 commits into from
Sep 8, 2022

Conversation

yamaguchi1024
Copy link
Member

No description provided.

@@ -715,6 +715,39 @@ def reorder_stmts(proc, block_cursor):
loopir = Schedules.DoReorderStmt(loopir, s1, s2).result()
return Procedure(loopir, _provenance_eq_Procedure=proc)

@sched_op([ExprCursorA(many=True)])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this operation apply to a single location or many locations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with both, do you have a suggestion?

@gilbo
Copy link
Contributor

gilbo commented Aug 4, 2022

This scheduling op should probably have a more specific name than commute. Maybe commute_expr is sufficient. But are + and * commutativity the only possible thing that the phrase commute_expr might mean?

@yamaguchi1024
Copy link
Member Author

I'm fine with both commute and commute_expr, latter is a bit harder to type though

@yamaguchi1024 yamaguchi1024 merged commit 2814c5f into master Sep 8, 2022
@yamaguchi1024 yamaguchi1024 deleted the commute branch September 8, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants