Accomodate Seq in bind_expr, fission_after, add_loop, double fission #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreinking
requested changes
Jun 24, 2022
src/exo/LoopIR_scheduling.py
Outdated
| @@ -1092,7 +1092,7 @@ def map_s(self, s): | |||
|
|
|||
| if isinstance(s, (LoopIR.ForAll, LoopIR.Seq)): | |||
| body = self.process_block(s.body) | |||
| return [LoopIR.ForAll(s.iter, s.hi, body, s.eff, s.srcinfo)] | |||
| return [type(s)(s.iter, s.hi, body, s.eff, s.srcinfo)] | |||
There was a problem hiding this comment.
Use s.update(body=body)
|
We have a helper for this. Might as well use it. |
src/exo/LoopIR_scheduling.py
Outdated
| @@ -2154,17 +2154,17 @@ def map_s(self, s): | |||
| # body doesn't depend on the loop | |||
| # and the body is idempotent | |||
| if s.iter in _FV(pre) or not _is_idempotent(pre): | |||
| pre = [LoopIR.ForAll(s.iter, s.hi, pre, None, s.srcinfo)] | |||
| pre = [type(s)(s.iter, s.hi, pre, None, s.srcinfo)] | |||
There was a problem hiding this comment.
s.update(body=pre, eff=None)
|
Hmm isn't this okay? The helper is not used in other parts of this file |
I didn't retroactively replace all of these with the helper, but that doesn't mean we shouldn't use it in new code. |
|
I'll fix this ASAP! |
added 2 commits
June 24, 2022 10:54
alexreinking
approved these changes
Jun 24, 2022
yamaguchi1024
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.