Refactoring the API as part of Effect-Check/API audit #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 80.13% 80.13%
=======================================
Files 32 32
Lines 2885 2885
=======================================
Hits 2312 2312
Misses 573 573 Continue to review full report at Codecov.
|
alexreinking
approved these changes
May 10, 2022
Comment on lines
+1327
to
+1328
| return [type(s)( s.name, s.type, s.cast, | ||
| idx, rhs, None, s.srcinfo )] |
There was a problem hiding this comment.
Just a reminder that we have this nice new update function that makes this sort of code easier to read/write.
Suggested change
| return [type(s)( s.name, s.type, s.cast, | |
| idx, rhs, None, s.srcinfo )] | |
| return [s.update(idx=idx, rhs=rhs, eff=None)] |
|
@gilbo Did |
|
I can’t recall, but I think the order made less sense to me. We’ll want to organize this better in the future regardless.
… On May 10, 2022, at 2:04 PM, Yuka Ikarashi ***@***.***> wrote:
@gilbo Did data_reuse and delete_config changed their locations? What was the motivation for that?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.
|
|
@gilbo Sure, this change looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These should all be extremely trivial changes; just trying to separate from more meaningful changes in a later PR.