Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated par loops from reorder and split #184

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Remove deprecated par loops from reorder and split #184

merged 1 commit into from
Apr 20, 2022

Conversation

skeqiqevian
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Apr 11, 2022 •
edited
Loading

Codecov Report

Merging #184 (3732f2b) into master (0a61a74) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   79.99%   79.99%           
=======================================
  Files          32       32           
  Lines        2854     2854           
=======================================
  Hits         2283     2283           
  Misses        571      571

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a61a74...3732f2b. Read the comment docs.

gilbo
gilbo reviewed Apr 11, 2022
View reviewed changes
Copy link
Contributor

@gilbo gilbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it necessary to change the tests in order for them to pass?

@yamaguchi1024 yamaguchi1024 marked this pull request as draft April 12, 2022 00:53
@yamaguchi1024 yamaguchi1024 marked this pull request as ready for review April 20, 2022 20:51
@yamaguchi1024 yamaguchi1024 enabled auto-merge (squash) April 20, 2022 20:51
@yamaguchi1024 yamaguchi1024 merged commit 47d800e into master Apr 20, 2022
@yamaguchi1024 yamaguchi1024 deleted the remove_par branch April 20, 2022 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilbo gilbo gilbo left review comments

@yamaguchi1024 yamaguchi1024 yamaguchi1024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skeqiqevian @gilbo @yamaguchi1024