-
Notifications
You must be signed in to change notification settings - Fork 857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support local model with inference-engine mlx #475
base: main
Are you sure you want to change the base?
Conversation
I like the idea here, but think rather than rely on a folder structure this should use config files or command line arguments to specify paths to model implementations and populate things like the model card list at runtime. I'm considering refactoring the inference engine to take model implementations by default and use the shard downloader as one of a few possible routes to get weights, and I think automatically instantiating and parsing a default directory structure for this purpose creates a lot of potential for issues down the line |
f6fc665
to
438eae4
Compare
@blindcrone |
Enhancement: support local and custom models #165
This is a modified version of the code that I've made functional, although the code quality may not be ideal. It supports running local path models using mlx for both CLI and ChatAPI. However, I've encountered an issue where the response quality from the CLI is subpar. I would appreciate any suggestions on how to improve or optimize the code for better results.
Changes: