fix(ruff): reword prose comment so inner # noqa: isn't parsed as a directive - #48
Conversation
…directive run_agent.py:107 had a prose comment containing a literal `# noqa: F401` inside backticks. ruff 0.15.20 parses that inner token as a real noqa directive and errors (trailing prose isn't a valid code list), failing the blocking ruff check on every open PR that branches off live-config. Reword to 'noqa F401' without changing meaning. Real trailing # noqa: F401 directives on the import lines are untouched. ruff check run_agent.py passes. Patch note: ~/.hermes/plans/hermes-patches/fix-ruff-invalid-noqa-comment.md
There was a problem hiding this comment.
Code Review
This pull request updates a comment in run_agent.py to remove the # symbol and backticks from the mention of noqa F401. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
🔎 Lint report:
|
| Rule | Count |
|---|---|
PLW1514 |
1 |
First entries
gateway/run.py:5594: [PLW1514] `open` in text mode without explicit `encoding` argument
✅ Fixed issues (1):
| Rule | Count |
|---|---|
PLW1514 |
1 |
First entries
../../../../../tmp/lint-base/gateway/run.py:5594: [PLW1514] `open` in text mode without explicit `encoding` argument
Unchanged: 0 pre-existing issues carried over.
ty (type checker)
Total: 11574 on HEAD, 11574 on base (➖ 0)
🆕 New issues: none
✅ Fixed issues: none
Unchanged: 6094 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
|
Babysit pass: merge-ready. The targeted error is fixed — |
Summary
Fixes a pre-existing CI-blocking ruff error on
live-configthat fails the blocking ruff check on every open PR (they all branch off live-config), blocking the whole queue (#46, #47, incoming PACE-fix PR).The bug
run_agent.py:107had a prose comment containing a literal`# noqa: F401`inside backticks. ruff 0.15.20 parses that inner token as a real noqa directive and errors because the trailing prose isn't a valid code list:The fix
Reword the prose comment so ruff no longer sees a parseable
# noqa:token, without changing meaning:The real, load-bearing trailing
# noqa: F401directives on the actual import lines (112, 113, 137, 139, 140, ...) are untouched.Verify
No more "Invalid
# noqadirective" warning.One logical change only. Patch note:
~/.hermes/plans/hermes-patches/fix-ruff-invalid-noqa-comment.md.