Skip to content

fix(signal): drop empty metadata events and surface reactions #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
exiao merged 1 commit into from
Apr 23, 2026
Merged

fix(signal): drop empty metadata events and surface reactions #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions gateway/platforms/signal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,17 @@ async def _handle_envelope(self, envelope: dict) -> None:
if text and mentions:
text = _render_mentions(text, mentions)

# Handle reactions — surface the emoji so the model sees it
reaction_data = data_message.get("reaction")
if reaction_data and not text:
emoji = reaction_data.get("emoji", "")
if emoji:
# "remove" key means the user un-reacted — skip silently
if reaction_data.get("isRemove"):
logger.debug("Signal: ignoring reaction removal from %s", redact_phone(sender))
return
text = f"[reacted {emoji}]"

# Extract quote (reply-to) context from Signal dataMessage
quote_data = data_message.get("quote") or {}
reply_to_id = str(quote_data.get("id")) if quote_data.get("id") else None
Expand Down Expand Up @@ -529,6 +540,22 @@ async def _handle_envelope(self, envelope: dict) -> None:
logger.debug("Signal: message from %s in %s: %s",
redact_phone(sender), chat_id[:20], (text or "")[:50])

# Guard: drop messages with no text and no media. These are typically
# Signal metadata events (expiration timer, profile key, group updates,
# remote deletes, stickers without a fallback) that slipped past the
# dataMessage check above. Log the keys so we can identify what kinds
# of events are being dropped and whether we should handle them.
if not (text or "").strip() and not media_urls:
dm_keys = sorted(data_message.keys())
logger.info(
"Signal: dropping empty message from %s — "
"dataMessage keys: %s, raw snippet: %.300s",
redact_phone(sender),
dm_keys,
{k: data_message[k] for k in dm_keys if k != "groupInfo"},
)
return

await self.handle_message(event)

# ------------------------------------------------------------------
Expand Down
Loading