Skip to content

fix(modal): cancel a command without destroying the sandbox #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
exiao merged 18 commits into from
Jul 27, 2026
Merged

fix(modal): cancel a command without destroying the sandbox #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
e58aa78
fix(modal): cancel a command without destroying the sandbox
exiao Jul 26, 2026
f11edef
fix(modal): record the command PID instead of an env marker
exiao Jul 26, 2026
774ab48
fix(modal): escalate to the process group unconditionally
exiao Jul 26, 2026
c47464d
fix(modal): wait for the command to register before giving up on cancel
exiao Jul 26, 2026
4f88a90
fix(modal): replay a cancel that arrives before the command launches
exiao Jul 26, 2026
53a5a1c
fix(modal): coordinate cancellation with exec startup
exiao Jul 26, 2026
3f64cf6
fix(modal): swallow pending cancel replay failures
exiao Jul 26, 2026
183d076
fix(modal): clean cancellation pid files on exit
exiao Jul 26, 2026
56dd8f7
fix(modal): survive a command's own EXIT trap and a spaced comm
exiao Jul 27, 2026
6e9d01b
fix(modal): move pid-file cleanup out of the command's shell
exiao Jul 27, 2026
1ee092c
fix(modal): keep pid-file cleanup off the command's timed path
exiao Jul 27, 2026
0826002
fix(modal): sweep stale pid files instead of reaping per command
exiao Jul 27, 2026
d091b48
test(modal): drive cancellation through execute() and drop source ins…
exiao Jul 27, 2026
a0c374c
fix(modal): kill descendants that detach from the process group
exiao Jul 27, 2026
d1cd150
test(modal): assert the pgid parser's output, not its shell text
exiao Jul 27, 2026
3dad56d
test(modal): replace the remaining change-detector tests with behavio…
exiao Jul 27, 2026
d831ca1
fix(modal): record the process group so cancel survives the wrapper e…
exiao Jul 27, 2026
2c4f9b3
test(modal): compare only the PID field of the pid-file record
exiao Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading