Skip to content

Commit

Permalink
Fix icon issue for chromium/edge
Browse files Browse the repository at this point in the history
  • Loading branch information
exhuma committed Jul 27, 2022
1 parent ed99242 commit b1f33ce
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,13 @@ FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}
RUN apt update && \
DEBIAN_FRONTEND=noninteractive \
apt -y install \
inkscape \
libnotify-bin \
pandoc \
vim-nox \
python3 \
python3-pip \
python3-venv \
vim-nox \
jq && \
pip3 install pre-commit

Expand Down
6 changes: 6 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ mozilla: pages bundled_docs
chrome: pages bundled_docs
mkdir -p unpackaged/chrome/src/core
cp -r build/pages/* unpackaged/chrome/
inkscape -w 48 -h 48 public/assets/icon.svg \
-o unpackaged/chrome/assets/icon48.png
inkscape -w 96 -h 96 public/assets/icon.svg \
-o unpackaged/chrome/assets/icon96.png
inkscape -w 128 -h 128 public/assets/icon.svg \
-o unpackaged/chrome/assets/icon128.png
sed -e 's/__version__/$(CURRENT_VERSION)/' \
manifest-chrome.json > unpackaged/chrome/manifest.json

Expand Down
6 changes: 3 additions & 3 deletions manifest-chrome.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
"author": "Michel Albert",
"homepage_url": "https://github.com/exhuma/schmackhaft",
"icons": {
"48": "/assets/icon.svg",
"96": "/assets/icon.svg",
"128": "/assets/icon.svg"
"48": "/assets/icon48.png",
"96": "/assets/icon96.png",
"128": "/assets/icon128.png"
},
"action": {
"default_icon": {
Expand Down

0 comments on commit b1f33ce

Please sign in to comment.