🤖 Flatten authors and contributors in .meta/config.json files #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The authors and contributors of exercises are stored in an array in the exercises' `.meta/config.json` files. We used to have separate fields for the GitHub- and Exercism username of the user. As we're only using the GitHub username, we've flatten the `authors` and `contributors` array to an array of strings representing the GitHub usernames. See https://github.com/exercism/docs/pull/90/files
coriolinus
approved these changes
Mar 23, 2021
iHiD
reviewed
Mar 23, 2021
Member
iHiD
left a comment
iHiD
left a comment
There was a problem hiding this comment.
We are now merging this PR automatically to help prepare your track for Exercism v3.
Member
Author
|
@coriolinus We're building a new release of configlet right now. Should be there in 15-30 minutes. |
Member
|
(for clarity - my comment was automated 🙂) |
Member
Author
|
@coriolinus configlet has been updated and I restarted the job. It is green now :) Feel free to merge this once the other checks are green. |
ghost
self-requested a review
ghost
approved these changes
Mar 23, 2021
|
Given this is approved I will merge since I merged two other PRs that are failing on main. |
|
In general, I believe Rust maintainers defer to the contributor or initiating maintainer to self-merge. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authors and contributors of exercises are stored in an array of objects in the exercises'
.meta/config.jsonfiles.Each author/contributor used to have two properties: their GitHub username and their Exercism username.
As we're only using the GitHub username, we're flattening the
authorsandcontributorsarray to an array of strings representing the GitHub usernames.We will update
configletto validate the new structure, so you might be seeing build failures once we've implemented this change.See https://github.com/exercism/docs/pull/90/files
Automatic Merging
We will automatically merge this PR immediately to be able to submit a different PR in which we'll add the authors/contributors for practice exercises.
Tracking
exercism/v3-launch#26