remove legacy metadata.yml files #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combine v2 `metadata.yml` values into the v3 `config.json`. Note I have not touched the `exercise` utility which still generates `metadata.yml`. Close #1166.
ghost
changed the title
coriolinus
approved these changes
Mar 23, 2021
Member
coriolinus
left a comment
coriolinus
left a comment
There was a problem hiding this comment.
Looks fine. Did you do this by hand, or with a script? If with a script, would you post a link to a gist, or if short, just in a comment or something? I prefer to make scripts like this--even one-offs--available in the history.
Author
By hand unfortunately.
I love that strategy too. Thanks for teaching me! |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combine v2
metadata.ymlvalues into the v3config.json.Note I have not touched the
exerciseutility which still generatesmetadata.yml.Close #1166.