Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impliment new template based generator #1730
base: main
Are you sure you want to change the base?
Impliment new template based generator #1730
Changes from 8 commits
77a991b
039911c
8e3afbe
d278534
5c27b41
b1f131f
7004988
067df32
653f629
4960f96
39bf79b
7fb52c5
e1c69f4
79b00d1
f806548
bbad039
b6d2e9e
98d267d
68d4671
76504b5
00af4d0
492b44b
f40f4c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typographical error (missing apostrophe) and preference of "positive conditional statement".
Prefer using
unless positive_conditional_statement
rather thanif negative
, this can keep all (or at least most) of our conditional statements positive.We should also consider if
RuntimeError
is the best error here. It could beVerificationError
instead, which would be more specific.We might also
fail
instead ofraise
for the communication that this is purposefully failed here, given the right conditions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case we move from TOML to another type of configuration file, this reference will not need to change in the documentation.