-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync palindrome products exercise with problem specification #1722
Conversation
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to apply the suggestions, they are simply to provide a blank line after visibility methods private
and public
as they do not affect only the following line.
private | ||
attr_reader :min, :max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private | |
attr_reader :min, :max | |
private | |
attr_reader :min, :max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vscode kept triggering rubocop and auto-formatting my code. I assumed that that's exercism's style.
I think this is the rule that's being followed:
Lines 37 to 38 in fa35ccc
Layout/EmptyLinesAroundAccessModifier: | |
EnforcedStyle: only_before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is stating that it is only enforcing the empty line before. But, while we are not enforcing that there is a blank line after (because sometimes that really does make sense) we may have a blank line, and so should likely have a blank line after, since the communication value is there.
public | ||
attr_reader :smallest, :largest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public | |
attr_reader :smallest, :largest | |
public | |
attr_reader :smallest, :largest |
I've added the blank lines. @kotp |
private | ||
attr_reader :min, :max |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is stating that it is only enforcing the empty line before. But, while we are not enforcing that there is a blank line after (because sometimes that really does make sense) we may have a blank line, and so should likely have a blank line after, since the communication value is there.
[As discussed on the forum]