Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parallel_letter_frequency_test.rb #1640

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Update parallel_letter_frequency_test.rb #1640

merged 1 commit into from
Mar 6, 2024

Conversation

iHiD
Copy link
Member

@iHiD iHiD commented Mar 5, 2024

Two changes:

  1. I think the texts should always be an array. It's a string in one case.
  2. There is punctuation used in the later tests that does not occur in the punctuation one.

Two changes:
1. I think the `texts` should always be an array. It's a string in one case.
2. There is punctuation used in the later tests that does not occur in the punctuation one.
Copy link
Contributor

github-actions bot commented Mar 5, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@kotp
Copy link
Member

kotp commented Mar 6, 2024

This is one commit for two changes.

I like the the second. The first, I think, is tested in such a way that we probably want to not need to re-test any that are submitted. (not that there are many yet.)

@iHiD iHiD merged commit 770b01c into main Mar 6, 2024
6 checks passed
@iHiD iHiD deleted the iHiD-patch-1 branch March 6, 2024 13:24
@iHiD
Copy link
Member Author

iHiD commented Mar 6, 2024

Thanks! We'll need to rerun things as the working test runner only got deployed this morning, so I'll merge and do that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants