Add dnd_character exercise

[ccadden]

Add dnd_character exercise based on 48in24 implementation status page: https://exercism.org/challenges/48in24/implementation_status

And on the forums: https://forum.exercism.org/t/add-dnd-character-exercise/9492

[github-actions]

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

---

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

[kotp]

I converted to draft as it is still in progress.

[kotp]

I do not have much confidence that this is doing well what the test says it is doing.

    (attributes << :hitpoints).each do |attribute|
      expected = character.send(attribute)
      10.times do
        assert_equal expected, character.send(attribute)
      end

This would check each 10 (arbitrary choice) times, against what it was the answer for the first call

[kotp]

This table seems to be ABILITY_SCORE_TO_MODIFIER.

[kotp]

Suggested change

	`dnd_character_test.rb` pass.
	To get started with TDD, see the `README.md` file in your
	`dnd_character_test.rb` pass.
	To get started with TDD, see the `README.md` file in your

[iHiD]

@Mr-sigma @kotp Unless I'm missing something, the tests.toml and the tests themselves don't seem to be aligned. Compare this to C# for example: https://github.com/exercism/csharp/blob/main/exercises/practice/dnd-character/DndCharacterTests.cs

[kotp]

@Mr-sigma @kotp Unless I'm missing something, the tests.toml and the tests themselves don't seem to be aligned. Compare this to C# for example: https://github.com/exercism/csharp/blob/main/exercises/practice/dnd-character/DndCharacterTests.cs

The tests are not one to one in alignment, this is true. And CSharp having an exact one to one based on Problem Specification makes sense to me, since it is being generated, and it appears without any additional changes or removals from the Problem Specifications supplied information.

We should find that the tests do not need to be exact matches one to one, and may even be difficult to match, given the random nature of character generation, against a user written design, without likely driving a specific design or solution (and this is a practice exercise currently.)

The tests focus on the modification algorithm being applied, and the tests that attempt to ensure that the character attributes are changing randomly per character being generated, but also unchanging for the character once it is created.

We should find that the tests align in result, though, since deviation from that would be problematic if and when we decide to automate the tests, for example, and when bringing in problem descriptions from upstream.

Also, I think this pull request should still be in "Draft Mode" so we are still working through some things regarding the test and how it influences the solution.

[iHiD]

My understanding is that tests should align 1-1 with the tests.toml.

I've looked through many other tracks in case I misunderstood this, and they are all 1-1 to problem specs:

• https://github.com/exercism/javascript/blob/main/exercises/practice/dnd-character/dnd-character.spec.js
• https://github.com/exercism/bash/blob/main/exercises/practice/dnd-character/dnd_character.bats
• https://github.com/exercism/elixir/blob/main/exercises/practice/dnd-character/test/dnd_character_test.exs
• https://github.com/exercism/wren/blob/main/exercises/practice/dnd-character/dnd-character.spec.wren

I'll wait for @ErikSchierboom to weigh in on this on Tuesday, but my understanding of exercises Exercism-wide is that they should 1-1 align to tests.toml.

[kotp]

My understanding is that tests should align 1-1 with the tests.toml.

I've looked through many other tracks in case I misunderstood this, and they are all 1-1 to problem specs:

• https://github.com/exercism/javascript/blob/main/exercises/practice/dnd-character/dnd-character.spec.js
• https://github.com/exercism/bash/blob/main/exercises/practice/dnd-character/dnd_character.bats
• https://github.com/exercism/elixir/blob/main/exercises/practice/dnd-character/test/dnd_character_test.exs
• https://github.com/exercism/wren/blob/main/exercises/practice/dnd-character/dnd-character.spec.wren

I'll wait for @ErikSchierboom to weigh in on this on Tuesday, but my understanding of exercises Exercism-wide is that they should 1-1 align to tests.toml.

I will defer. When I was creating the generator, there were exercises that did not necessarily match up with Ruby, and I had made exceptions, but that was years ago, so it could have changed. I understand that many are like that, I just was not aware of the requirement to do so other than it being convenient to do so. (Some of the generators would conditional do things bringing in some tests, and making others or not do others.)

[kotp]

Looking good. The one to one testing as mentioned, but the tests assertion arguments are in reverse order for many of the tests.

[kotp]

Suggested change

	def initialize; end
	def self.modifier; end
	def self.modifier
	# Your Code Here
	end
	def initialize
	# Your code here
	end

[kotp]

In the tests, I believe it is supposed to be expected, actual in terms of the order of the statements.

We can verify this by setting them up to fail and seeing what the message is that is returned.

[kotp]

Suggested change

	assert_includes allowed_range, character.send(attribute)
	assert_includes allowed_range, character.send(attribute), "The expected value for #{attribute} is incorrect."

[kotp]

This one is in the correct order, the expected first, and then character hitpoints being actual.

Indeed, we could remove the expected_ from the name, or we could say only expected because the actual shows what kind of thing is expected based on the method being called on the object under test.

[ccadden]

@kotp I added your patches, rebased, and ran rubocop -d -A to align with the repo's style guidelines. Should be all set to go, thanks for the feedback!

[kotp]

I sent a patch, but am approving early.

I will accept your choice on the what you see there and what you choose to apply.

This is definitely looking good.

[ccadden]

@kotp, patch applied!

[kotp]

Remove redundant inline disables.

[kotp]

Thank you very much @Mr-sigma