-
-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve syntax error output #1567
Conversation
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
The change looks good, matching what you would get. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add comments in while we're here.
در تاریخ دوشنبه ۴ سپتامبر ۲۰۲۳، ۱۱:۵۴ Miranto ***@***.***>
نوشت:
… Improve syntax error output on array decomposition :
- on (a, b), (d) = fruits_vegetables decomposition, add a new syntax
error output
- on ((a, b), (d)) = fruits_vegetables decomposition, move the syntax
error output below
For two decomposition, having two distinct syntax errors outputs are more
clear rather than having only one syntax error output.
------------------------------
You can view, comment on, or merge this pull request online at:
#1567
Commit Summary
- 8ae25d5
<8ae25d5>
Improve syntax error output
File Changes
(1 file <https://github.com/exercism/ruby/pull/1567/files>)
- *M* exercises/concept/locomotive-engineer/.docs/introduction.md
<https://github.com/exercism/ruby/pull/1567/files#diff-78d9549cbdbeb7833c2f9a88ab44276ef0924935297b062befb25f4e17917413>
(4)
Patch Links:
- https://github.com/exercism/ruby/pull/1567.patch
- https://github.com/exercism/ruby/pull/1567.diff
—
Reply to this email directly, view it on GitHub
<#1567>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5CXY565YRJ4RET65X7WHE3XYV63DANCNFSM6AAAAAA4J7FNHM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
There are one each, and so two in total, and they are distinct. Is there a different change you would like to see? Please feel free to post and discuss in the forums. This merge request has been accepted and merged. You can use this link and let us know what you are thinking! |
Improve syntax error output on array decomposition :
(a, b), (d) = fruits_vegetables
decomposition, add a new syntax error output((a, b), (d)) = fruits_vegetables
decomposition, move the syntax error output belowFor two decomposition, having two distinct syntax errors outputs are more clear rather than having only one syntax error output.