Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve syntax error output #1567

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Improve syntax error output #1567

merged 2 commits into from
Sep 26, 2023

Conversation

m1ranto
Copy link
Contributor

@m1ranto m1ranto commented Sep 4, 2023

Improve syntax error output on array decomposition :

  • on (a, b), (d) = fruits_vegetables decomposition, add a new syntax error output
  • on ((a, b), (d)) = fruits_vegetables decomposition, move the syntax error output below

For two decomposition, having two distinct syntax errors outputs are more clear rather than having only one syntax error output.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Sep 4, 2023
@kotp kotp reopened this Sep 26, 2023
@kotp
Copy link
Member

kotp commented Sep 26, 2023

The change looks good, matching what you would get.

Copy link
Member

@iHiD iHiD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add comments in while we're here.

@kotp kotp merged commit a8b9c26 into exercism:main Sep 26, 2023
4 checks passed
@Benyam12
Copy link

Benyam12 commented Sep 26, 2023 via email

@kotp
Copy link
Member

kotp commented Sep 26, 2023

در تاریخ دوشنبه ۴ سپتامبر ۲۰۲۳،‏ ۱۱:۵۴ Miranto @.***> نوشت:

Improve syntax error output on array decomposition : - on (a, b), (d) = fruits_vegetables decomposition, add a new syntax error output - on ((a, b), (d)) = fruits_vegetables decomposition, move the syntax error output below For two decomposition, having two distinct syntax errors outputs are more clear rather than having only one syntax error output.

There are one each, and so two in total, and they are distinct.

Is there a different change you would like to see?

Please feel free to post and discuss in the forums. This merge request has been accepted and merged.

You can use this link and let us know what you are thinking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants