Fix rubocop error for the constant by converting to uppercase - new #1562
Conversation
|
https://forum.exercism.org/t/fix-rubocop-error-for-the-constant-by-converting-to-uppercase/6958/3 is the forum post for this PR. Pre-approved. |
|
|
||
| ```ruby | ||
| Port::Identifier | ||
| Port::IDENTIFIER |
There was a problem hiding this comment.
@meatball133 thoughts? Should we not have it as a comment, but have it as explicit code instead?
There was a problem hiding this comment.
Do you mean like in the stub file, that we give them the constant but let them define it by themself?
There was a problem hiding this comment.
Yeah. Because what is presented here is different than how they would likely define it, though by adding an equals sign and a value to this exact syntax, it could be assigned. I am not sure how important it is to tell them to define the constant if we give them that line in the code... seems like "check the box" rather than "see how a constant is defined", compared to this instruction set and having them find out how to define a constant in that name space.
It might be more straight forward just to do it for them. It is not a complex idea.
There was a problem hiding this comment.
Yeah, I am fine either, the goal is to teach how to define a symbol. So in a way, there is no need to have the define constant part, but that is some repetition on how to do it.
| @@ -1,5 +1,5 @@ | |||
| module Port | |||
| # TODO: define the 'Identifier' constant | |||
| # TODO: define the 'IDENTIFIER' constant | |||
There was a problem hiding this comment.
@meatball133 the comment earlier was specifically regarding this submitted version to the student.
kotp
added
enhancement
in progress
ruby
|
Thank you @egemen-dev . |
This PR fixes the rubocop issue of the Constant Name for the exercise concept of port-palermo. Since usage of uppercase constants are recommended by the rubocop docs and it is a good practice.
This PR is the new version of the previous one. I mistakenly deleted the previous one with the forked repo so, I had to open a new one.