Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instructions and tests for Anagram exercise #185

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

stragu
Copy link

@stragu stragu commented Sep 2, 2021

This PR fixes a few things:

  • The instructions a clearer, as they now make it obvious that:
    • The output needs to be a vector (not a list)
    • The match needs to be case-insensitive
    • Same words shouldn't be matched
  • The tests are now more flexible: they check for a length of 0 for empty vectors, instead of an equality to c(). This fixes the issue of users submitting a valid solution that returns an empty vector of mode character and having tests failing because of that.

@jonmcalder
Copy link
Member

Thanks for the PR and sorry for the delay in following up!

I'm happy with the changes to the tests you propose and will accept those.

Regarding the instructions: these are generally not meant to be track specific (by design) and are automatically synced from the problem specifications repo.

e.g. the use of the term list is incidental and shouldn't imply the list datatype in R (which is rather unfortunate I know)

In general I think there is a bit of an expectation that students should be able to learn to deduce what's required from the tests themselves (as that's a valuable part of the learning process), but that being said if you're suggesting these changes to the instructions because of things that tripped you up and you feel that there should be further clarification in the instructions then the place to add these is in .docs/instructions.append.md as outlined here.

Could I ask you to please update your PR to expand on / clarify the existing instructions rather than modifying them directly?

And thanks again - I appreciate you contributing to the R track!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants