Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diamond: sync expected test results and input data with problem-specifications #1790

Merged
merged 8 commits into from
May 24, 2019

Conversation

BethanyG
Copy link
Member

Part of #1762

  • Changed expected return type to list from string in tests to conform with canonical-data.json.
  • Changed self.assertMultiLineEqual to assertEqual in tests. With a list now being required, a simple assertEqual will work.
  • Changed function name to rows in tests, example.py, and exercise stub to conform with canonical-data.json.
  • Changed function argument name to letter in example.py, and exercise stub to conform with canonical-data.json.

BethanyG and others added 7 commits April 4, 2019 01:42
merging in changes in order to run configlet
merge in most recent to prep for test editing.
…fications and update example solution."

This reverts commit b4e3777.
Wanted this in it's own branch.
Pulling in most recent exercise changes
merge in changes from main repo
@BethanyG BethanyG requested a review from a team as a code owner May 23, 2019 22:31
@cmccandless cmccandless merged commit df639af into exercism:master May 24, 2019
@cmccandless
Copy link
Contributor

Merged; thanks for working on this!

@BethanyG BethanyG deleted the diamond-changes branch May 29, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants