Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary-search: sync expected test inputs with problem-specifications #1783

Merged
merged 7 commits into from
May 23, 2019

Conversation

BethanyG
Copy link
Member

Changed test cases to expect find as the function name to conform with the cannonical-data.json. Change the example code to have find as the function name.

BethanyG and others added 5 commits April 4, 2019 01:42
merging in changes in order to run configlet
merge in most recent to prep for test editing.
…fications and update example solution."

This reverts commit b4e3777.
Wanted this in it's own branch.
@BethanyG BethanyG requested a review from a team as a code owner May 22, 2019 23:40
@BethanyG
Copy link
Member Author

Binary-Search changes - #1762

Copy link
Contributor

@cmccandless cmccandless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding your comments on whether the use of the name find was safe in Python: it won't shadow because we aren't overriding str.find() specifically, so it's safe.

@cmccandless cmccandless merged commit 4a775f0 into exercism:master May 23, 2019
@cmccandless
Copy link
Contributor

Merged; thanks for working on this!

@BethanyG BethanyG deleted the binary-search-changes branch May 29, 2019 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants