Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anagram: Add unicode tests #2366

Merged
merged 1 commit into from
Jan 24, 2024
Merged

anagram: Add unicode tests #2366

merged 1 commit into from
Jan 24, 2024

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Jan 23, 2024

@senekor senekor merged commit 524e2b3 into main Jan 24, 2024
7 checks passed
@senekor senekor deleted the anagram-unicode branch January 24, 2024 11:36
@mvuets
Copy link

mvuets commented Jun 13, 2024

Although it's very nice to teach how to handle Unicode, now these two new tests contradict the task statement, namely:

The target and candidates are words of one or more ASCII alphabetic characters (A-Z and a-z).

Shall the file instructions.md be update accordingly as well?

@IsaacG
Copy link
Member

IsaacG commented Jun 13, 2024

Although it's very nice to teach how to handle Unicode, now these two new tests contradict the task statement, namely:

The target and candidates are words of one or more ASCII alphabetic characters (A-Z and a-z).

Shall the file instructions.md be update accordingly as well?

That's a good question to post on the linked forum topic!

@mvuets
Copy link

mvuets commented Jun 13, 2024

That's a good question to post on the linked forum topic!

Ah, the Exercism accounts are automatically synced with the Discourse forum-- how thoughtful and sweet! (-: Will post my question there too then. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants