Proposed new exercise: Eliud's Eggs #2333

keiravillekode · 2023-10-12T10:14:18Z

Count the 1 bits in a number.

Name and description by @vaeng
https://forum.exercism.org/t/new-exercise-suggestion-pop-count/7632

Example implementation:
exercism/vlang@main...keiravillekode:vlang:eliuds-eggs

Nibbly November implementations (mips, wasm, x86-64-assembly) to follow.

website-icons issue: exercism/website-icons#159

@vaeng

Count the 1 bits in a number. Name and description by @vaeng https://forum.exercism.org/t/new-exercise-suggestion-pop-count/7632

github-actions · 2023-10-12T10:14:33Z

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

Fix issues lint reported in eliuds-eggs description.

ErikSchierboom

Lovely work! Just a few couple of comments.

ErikSchierboom · 2023-10-13T07:30:17Z

exercises/eliuds-eggs/metadata.toml

@@ -0,0 +1,2 @@
+title = "Eliud's Eggs"
+blurb = "Count the 1 bits in a number"


I would add your name and vaeng's as source and the forum URL as source_url:

Suggested change

blurb = "Count the 1 bits in a number"

blurb = "Count the 1 bits in a number"

source = "keiravillekode, vaeng"

source_url = "https://forum.exercism.org/t/new-exercise-suggestion-pop-count/7632/4"

We did something similar for resistor-color: https://github.com/exercism/problem-specifications/blob/main/exercises/resistor-color/metadata.toml

P.S. I don't know if you'd like to use your own name or you nickname as source (same goes for vaeng)

My real name is fine :)

source and source_url added

exercises/eliuds-eggs/description.md

ErikSchierboom · 2023-10-13T07:32:11Z

exercises/eliuds-eggs/description.md

@@ -0,0 +1,50 @@
+# Description
+
+Your friend Eliud inherited a farm from her grandma Tigist. Her granny was an inventor and had a tendency to build things in an overly complicated manner. The chicken coop has a digital display showing an encoded number representing the positions of all eggs that could be picked up.


Could you use a single line per sentence?

Suggested change

Your friend Eliud inherited a farm from her grandma Tigist. Her granny was an inventor and had a tendency to build things in an overly complicated manner. The chicken coop has a digital display showing an encoded number representing the positions of all eggs that could be picked up.

Your friend Eliud inherited a farm from her grandma Tigist.

Her granny was an inventor and had a tendency to build things in an overly complicated manner.

The chicken coop has a digital display showing an encoded number representing the positions of all eggs that could be picked up.

I should have written the forum post that way. Next time :)

now using one line per sentence

ErikSchierboom · 2023-10-13T07:34:28Z

exercises/eliuds-eggs/canonical-data.json

+    {
+      "uuid": "559e789d-07d1-4422-9004-3b699f83bca3",
+      "description": "pop-count of 0",
+      "property": "popCount",


Not sure that I have a better suggestion, but does popCount fit the domain? I wonder if eggCount is a more descriptive name.

Yup, all eggs, please. That makes it easier for users to see the connection.

Now using eggCount for function name,

ErikSchierboom · 2023-10-13T07:38:24Z

exercises/eliuds-eggs/canonical-data.json

+  "cases": [
+    {
+      "uuid": "559e789d-07d1-4422-9004-3b699f83bca3",
+      "description": "pop-count of 0",


Maybe the description could focus a bit more on what makes this case unique. In this case, an alternative description could be:

Suggested change

"description": "pop-count of 0",

"description": "no eggs",

or:

Suggested change

"description": "pop-count of 0",

"description": "all zeros",

I would also suggest to make the descriptions about eggs, rather than the mechanics behind it.

Descriptions updated

ErikSchierboom · 2023-10-13T07:39:10Z

@exercism/reviewers I'd appreciate you all taking a look at this too. We could use this exercise for Nibbly November.

IsaacG · 2023-10-13T09:25:14Z

exercises/eliuds-eggs/canonical-data.json

@@ -0,0 +1,50 @@
+{
+  "exercise": "eliuds-eggs",


I think all the practice exercises have more direct names which map to the problem being solved, like pop count. I may be mistaken but I think the cute names are only used in concept exercises.

Exercise renamed to Pop Count

ErikSchierboom · 2023-10-13T13:00:45Z

exercises/pop-count/canonical-data.json

+  "cases": [
+    {
+      "uuid": "559e789d-07d1-4422-9004-3b699f83bca3",
+      "description": "all zeros",


For consistency, maybe do:

Suggested change

"description": "all zeros",

"description": "0 eggs",

IsaacG · 2023-10-13T16:25:29Z

exercises/pop-count/introduction.md

+1. Scan the potential egg-laying spots and mark down a `1` for an existing egg or a `0` for an empty spot.
+2. Convert the number from binary to decimal
+3. Show the result on the display


Suggested change

1. Scan the potential egg-laying spots and mark down a `1` for an existing egg or a `0` for an empty spot.

2. Convert the number from binary to decimal

3. Show the result on the display

1. Scan the potential egg-laying spots and mark down a `1` for an existing egg or a `0` for an empty spot.

2. Convert the number from binary to decimal.

3. Show the result on the display.

keiravillekode · 2023-10-13T23:30:00Z

All comments addressed

from exercism/problem-specifications#2333

Proposed new exercise: Eliud's Eggs

b8778ed

Count the 1 bits in a number. Name and description by @vaeng https://forum.exercism.org/t/new-exercise-suggestion-pop-count/7632

keiravillekode requested a review from a team as a code owner October 12, 2023 10:14

github-actions bot closed this Oct 12, 2023

keiravillekode mentioned this pull request Oct 12, 2023

Icon for practice exercise Eliud’s Eggs exercism/website-icons#159

Closed

Address Markdown lint warnings

ddb707f

Fix issues lint reported in eliuds-eggs description.

ErikSchierboom reopened this Oct 12, 2023

ErikSchierboom reviewed Oct 13, 2023

View reviewed changes

IsaacG reviewed Oct 13, 2023

View reviewed changes

Rename proposed exercise Eliud's Eggs to Pop Count

a6cafdd

ErikSchierboom reviewed Oct 13, 2023

View reviewed changes

IsaacG reviewed Oct 13, 2023

View reviewed changes

Each calculation step ends with a '.'_

674d70e

IsaacG approved these changes Oct 14, 2023

View reviewed changes

ErikSchierboom approved these changes Oct 16, 2023

View reviewed changes

kotp approved these changes Oct 17, 2023

View reviewed changes

kotp merged commit fbb50d2 into exercism:main Oct 17, 2023
7 checks passed

keiravillekode deleted the eliuds-eggs branch October 17, 2023 07:24

keiravillekode mentioned this pull request Oct 17, 2023

feat: add pop-count exercise exercism/vlang#162

Merged

BNAndras mentioned this pull request Oct 17, 2023

Add pop-count exercise exercism/haxe#276

Merged

This was referenced Oct 18, 2023

New exercise: Pop Count exercism/8th#108

Merged

New exercise: Pop Count exercism/jq#190

Merged

glennj added a commit to glennj/exercism-tcl that referenced this pull request Oct 18, 2023

New exercise: Pop Count

77a0009

from exercism/problem-specifications#2333

glennj mentioned this pull request Oct 18, 2023

New exercise: Pop Count exercism/tcl#303

Merged

glennj added a commit to exercism/tcl that referenced this pull request Oct 18, 2023

New exercise: Pop Count (#303)

76be026

from exercism/problem-specifications#2333

BNAndras mentioned this pull request Oct 19, 2023

Implement new pop-count exercism/elm#615

Closed

sanderploegsma mentioned this pull request Oct 28, 2023

Add practice exercise pop-count exercism/java#2540

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Proposed new exercise: Eliud's Eggs #2333

Proposed new exercise: Eliud's Eggs #2333

keiravillekode commented Oct 12, 2023 •

edited

Loading

github-actions bot commented Oct 12, 2023

ErikSchierboom left a comment

ErikSchierboom Oct 13, 2023 •

edited

Loading

vaeng Oct 13, 2023

keiravillekode Oct 13, 2023

ErikSchierboom Oct 13, 2023

vaeng Oct 13, 2023

keiravillekode Oct 13, 2023

ErikSchierboom Oct 13, 2023

vaeng Oct 13, 2023

keiravillekode Oct 13, 2023

ErikSchierboom Oct 13, 2023

vaeng Oct 13, 2023

keiravillekode Oct 13, 2023

ErikSchierboom commented Oct 13, 2023

IsaacG Oct 13, 2023

keiravillekode Oct 13, 2023

ErikSchierboom Oct 13, 2023

IsaacG Oct 13, 2023

keiravillekode commented Oct 13, 2023

		@@ -0,0 +1,2 @@
		title = "Eliud's Eggs"
		blurb = "Count the 1 bits in a number"

		@@ -0,0 +1,50 @@
		# Description

		Your friend Eliud inherited a farm from her grandma Tigist. Her granny was an inventor and had a tendency to build things in an overly complicated manner. The chicken coop has a digital display showing an encoded number representing the positions of all eggs that could be picked up.

Proposed new exercise: Eliud's Eggs #2333

Proposed new exercise: Eliud's Eggs #2333

Conversation

keiravillekode commented Oct 12, 2023 • edited Loading

github-actions bot commented Oct 12, 2023

ErikSchierboom left a comment

Choose a reason for hiding this comment

ErikSchierboom Oct 13, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ErikSchierboom commented Oct 13, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keiravillekode commented Oct 13, 2023

keiravillekode commented Oct 12, 2023 •

edited

Loading

ErikSchierboom Oct 13, 2023 •

edited

Loading