sync etl #868
sync etl #868
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
tomasnorre
added
x:action/sync
| /** | ||
| * uuid 60dbd000-451d-44c7-bdbb-97c73ac1f497 | ||
| * @testdox single score with multiple letters | ||
| */ | ||
| public function testTransformMoreValues(): void | ||
| { | ||
| $old = ['1' => str_split('AEIOU')]; |
There was a problem hiding this comment.
Please replace all the str_split() runtime created arrays with literal arrays like we have in canonical data. Also canonical data asks for integer keys into the array, so make all the keys integers:
| $old = ['1' => str_split('AEIOU')]; | |
| $old = [1 => ["A", "E", "I", "O", "U"]]; |
This shows the actual input to the students and is as requested by canonical data. It also should not break any existing solutions.
Resolves #854