-
-
Notifications
You must be signed in to change notification settings - Fork 9
Fix run-tests so it looks for "exemplar' in concept exercises. #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
In concept exercises, `.meta/config.json` use the key "exemplar" for the solution example file while practice exercises look for the key "example". I added some logic in run-test.sh to pick the correct key based on the exercise being tested. This is preventing PR exercism#81 to pass the GHA tests.
|
A couple of other things to do:
|
|
Ah, except that |
Updated gen-exercise.sh to: - Allow command line options for author, difficulty (practice only), blurb (concept only), the type of exercise (practice - default - or concept) - Generate stub files for concept exercises (there is no problem specification for them so this is fairly barebone) - Handled parameters for concept exercises that `configlet lint` flagged but `configlet create` didn't manage ;-) Added an exemplar entry to config.json in the file section, again for concept exercises.
|
@glennj , I did update gen-exercise.sh to generate either a practice or concept exercise per your advises. There was a couple of things that Take a look and let me know what you think. |
We currently have a tool to generate scaffolding for a concept exercise (gen-exercise.sh as of PR exercism#89) but no tool to create the concept itself. Configlet doesn't provide such an option either. This tool is modeled after gen-exercise and will create all the files required for a concept with some comments describing what each file should contain (similar to the raw versions of the files in the top-level 'docs/' folder of the track). It will also add the concept information to the top-level `config.json`. There was also a mis-formatting in config.json, this was corrected here so it doesn't show up in the next unrelated exercise pull request.
|
@glennj, I wanted to change the title of the PR but that doesn't seem possible in github. It contains a revised version of gen-exercise.sh that can generate concept exercises as well as practice exercises. |
In concept exercises,
.meta/config.jsonuse the key "exemplar" for the solution example file while practice exercises look for the key "example". I added some logic in run-test.sh to pick the correct key based on the exercise being tested.This is preventing PR #81 to pass the GHA tests.