Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RationalTest.java #2886

Closed
wants to merge 2 commits into from
Closed

Update RationalTest.java #2886

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bdd96e
Update RationalTest.java
stamatisn Dec 28, 2024
5f56c2b
Merge branch 'main' into main
stamatisn Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion exercises/practice/rational-numbers/src/test/java/RationalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ public class RationalTest {
private static final double DOUBLE_EQUALITY_TOLERANCE = 1e-15;

private void assertDoublesEqual(double x, double y) {
assertThat(x).isEqualTo(y, within(DOUBLE_EQUALITY_TOLERANCE));
assertThat(x, closeTo(y, within (DOUBLE_EQUALITY_TOLERANCE));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the AssertJ examples, I was wondering if this is what you meant?

Suggested change
assertThat(x, closeTo(y, within (DOUBLE_EQUALITY_TOLERANCE));
assertThat(x).isCloseTo(y, within(DOUBLE_EQUALITY_TOLERANCE));

Otherwise this doesn't compile:

/home/runner/work/java/java/exercises/practice/rational-numbers/src/test/java/RationalTest.java:14: error: ')' expected
> Task :practice:rational-numbers:compileStarterSourceJava
        assertThat(x, closeTo(y, within (DOUBLE_EQUALITY_TOLERANCE));

}

// Tests
Expand Down