Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding analyzer feedback for tim-from-marketing concept exercise #2754

Merged
merged 5 commits into from
Mar 31, 2024
Merged

Adding analyzer feedback for tim-from-marketing concept exercise #2754

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb0160d
Adding analyzer feedback for tim-from-marketing concept exercise
manumafe98 Mar 21, 2024
e7f3052
Adding another actionable comment when students use optionals
manumafe98 Mar 31, 2024
3c839f7
Update exercises/concept/tim-from-marketing/.meta/design.md
manumafe98 Mar 31, 2024
e310e84
Removing essential comment
manumafe98 Mar 31, 2024
3a3d90d
Removing essential comment
manumafe98 Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions exercises/concept/tim-from-marketing/.meta/design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,17 @@

- `strings`: strings will be compared to null and basic methods from strings will be called.
- `if-else-statements`: using a conditional statement.

## Analyzer

This exercise could benefit from the following rules in the [analyzer]:

- `essential`: If the student did not use the `null` expression in the `print` method, instruct the student to do so.
manumafe98 marked this conversation as resolved.
Show resolved Hide resolved
- `actionable`: If the solution uses `Optionals` to solve the exercise, encourage the student to try solving it differently.
manumafe98 marked this conversation as resolved.
Show resolved Hide resolved
- `informative`: If the solution uses `String.format`, instruct the student to use simple string concatenation instead.
Explain that `String.format` is significantly slower than concatenating strings and should be used in more complex scenarios.

If the solution does not receive any of the above feedback, it must be exemplar.
Leave a `celebratory` comment to celebrate the success!

[analyzer]: https://github.com/exercism/java-analyzer