Sync tests for practice exercise space age

[manumafe98]

pull request

This issue addresses: #2388

This one required a major reformat, due to tests passing a new parameter and also usage of a deprecated method setScale

{
  "uuid": "57b96e2a-1178-40b7-b34d-f3c9c34e4bf4",
  "description": "invalid planet causes error",
  "property": "age",
  "input": {
    "planet": "Sun",
    "seconds": 680804807
  },
  "expected": {
    "error": "not a planet"
  }
}

I used as reference the go track that is updated.

Reviewer Resources:

Track Policies

[sanderploegsma]

This is a good learning opportunity to show that sometimes we can choose not to implement a test from the canonical data: the design of the exercise is such that it doesn't allow any unknown planets, so the extra test case isn't applicable at all.

I double-checked how the C# implementation handled this and they chose not to include this test case. In my opinion we should follow their lead here, since the exercises are very similar.

So to conclude, please revert all changes and instead mark the new test as "not included" in .meta/tests.toml, along with a comment explaining why. It should look something like this:

[57b96e2a-1178-40b7-b34d-f3c9c34e4bf4]
description = "invalid planet causes error"
include = false
comment = "Excluded because the design of the exercise does not allow for arbitrary planets"

[manumafe98]

Perfect! Would be great if Exercism does the same across all tracks i guess? Because for example in the Go implementation it is applied.

[sanderploegsma]

Perfect! Would be great if Exercism does the same across all tracks i guess? Because for example in the Go implementation it is applied.

Well that is because they chose to implement it with a different method signature. If our exercise would have looked similar to that one, we might have chosen to include the test that checks for an invalid planet.

It is up to each track to choose how to implement each practice exercise according to that programming language's best practices. For Go, the choice of accepting a planet argument makes sense as it's not as object-oriented as Java and C#. It also doesn't really have the concept of enums, which would have been another way to restrict the values it accepts at compile-time.

[manumafe98]

Perfect! Would be great if Exercism does the same across all tracks i guess? Because for example in the Go implementation it is applied.

Well that is because they chose to implement it with a different method signature. If our exercise would have looked similar to that one, we might have chosen to include the test that checks for an invalid planet.

It is up to each track to choose how to implement each practice exercise according to that programming language's best practices. For Go, the choice of accepting a planet argument makes sense as it's not as object-oriented as Java and C#. It also doesn't really have the concept of enums, which would have been another way to restrict the values it accepts at compile-time.

Great! just in case i've maintained the removal of the depracated method setScale and applied what you suggested me to the tests in the .meta/tests.toml

[sanderploegsma]

This looks great!