Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concept enums with concept exercise logs-logs-logs #2496

Merged
merged 3 commits into from
Oct 3, 2023
Merged

Add concept enums with concept exercise logs-logs-logs #2496

merged 3 commits into from
Oct 3, 2023

Conversation

sanderploegsma
Copy link
Contributor

@sanderploegsma sanderploegsma commented Sep 27, 2023 •
edited
Loading

This adds a new concept enums and the corresponding concept exercise logs-logs-logs, forked from the C# track.

To do:

  • add concept to practice exercises in config.json

Reviewer Resources:

Track Policies

@sanderploegsma sanderploegsma added the x:size/large Large amount of work label Sep 27, 2023
@sanderploegsma sanderploegsma changed the title Add concept enums with exercise logs-logs-logs Add concept enums with concept exercise logs-logs-logs Sep 27, 2023
@sanderploegsma
Copy link
Contributor Author

Screenshot 2023-09-27 at 14 00 30

😈

ErikSchierboom
ErikSchierboom approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll let someone else judge the Java code

@sanderploegsma sanderploegsma merged commit bbac886 into main Oct 3, 2023
@sanderploegsma sanderploegsma deleted the add-concept-enums branch October 3, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrerfcsantos andrerfcsantos andrerfcsantos approved these changes

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

Assignees
No one assigned
Labels
x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sanderploegsma @ErikSchierboom @andrerfcsantos