Skip to content

Generate profile images in satori - #15

Merged
iHiD merged 2 commits into
mainfrom
satori-profile-pictures
Aug 13, 2026
Merged

Generate profile images in satori#15
iHiD merged 2 commits into
mainfrom
satori-profile-pictures

Conversation

@dem4ron

@dem4ron dem4ron commented Aug 13, 2026

Copy link
Copy Markdown
Member

resolves #13

@dem4ron
dem4ron requested a review from a team as a code owner August 13, 2026 15:03
index.js requires it at the top level, so without this the container
fails to start and every invocation errors - not just profiles, and
regardless of the RENDERER flag.

Same omission as the satori renderer in #11, which is a hint the file
list should be a directory copy rather than something to keep in sync by
hand.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018iQj4EdMfNsWP6NtFTqwUU
@iHiD

iHiD commented Aug 13, 2026

Copy link
Copy Markdown
Member

Pushed one fix before merging: profile_renderer.js wasn't in the Dockerfile's COPY, and index.js requires it at the top level — so the container would have failed to start and every invocation would have errored, profiles or not, regardless of RENDERER.

Same omission I made with satori_renderer.js in #11. Twice is a pattern: that explicit file list wants to be a directory copy, or a CI docker build would catch it. Worth a follow-up.

Everything else checks out — 45 tests pass, and I rendered all three fixtures. The profile output is a very close match, and the mixed-scripts fixture confirms this also resolves #12: CJK, Cyrillic and emoji all render where they were tofu before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Render profile images with satori too

2 participants