Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prime-factors: use slices package to sort and compare test cases #2771

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

zamai
Copy link
Contributor

@zamai zamai commented Mar 22, 2024

I think this PR would be automatically closed, but wanted to leave it anyway, maybe'll figure out the forum later, but my tiny code reduction PR will be here already.

In this PR I moved slice sorting and comparison to use standard libs slices package, removed helpers that we're necessary before generics were introduced.

Value of this PR - removes code, enhances readability, showcases useful tools of stdlib :)

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link%20&category=go ) to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Mar 22, 2024
@andrerfcsantos andrerfcsantos added the x:rep/small Small amount of reputation label Jul 27, 2024
Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. This is something I've been actually think of doing for a while now.

@andrerfcsantos andrerfcsantos merged commit c825ad5 into exercism:main Jul 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants