Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Go 1.20 #2609

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Conversation

andrerfcsantos
Copy link
Member

@andrerfcsantos andrerfcsantos commented Feb 26, 2023

Description

This PR prepares the main repo for the track upgrade to Go 1.20:

  • Updated CI to run Go 1.20
  • Set default version to 1.18 in the config file of gomod-sync
    • This means CI will also now require new exercises to have a go.mod set to 1.18
  • Updated all go.mod files to 1.18 (gomod-sync update)
  • Removed two notes mentioning the track is on Go 1.16
  • Updated golanci-lint to the most recent version

Related

PR that also should be merged for the track to be considered "upgraded":

This PR should be merged eventually, but there's no rush since Go currently doesn't have the representer or the analyzer enabled:

@andrerfcsantos andrerfcsantos added the x:rep/small Small amount of reputation label Feb 26, 2023
@andrerfcsantos andrerfcsantos changed the title Upgrade to Go 1.20 Update to Go 1.20 Feb 26, 2023
@andrerfcsantos andrerfcsantos marked this pull request as ready for review March 1, 2023 23:14
@andrerfcsantos
Copy link
Member Author

andrerfcsantos commented Mar 2, 2023

Before we merge this, I think we should also add go.mod to the files.invalidator of the exercises, what do you think @junedev?

A change to the version of the go.mod is not as drastic as the equivalent in other languages, and if students have the old 1.16 go.mod, their solution will work with the test generator. But it will limit the features they can use (unless they update + submit the go.mod themselves) and I'm not sure there's other way to notify them the go.mod changed other than prompting for an exercise update.

cc @ErikSchierboom

@ErikSchierboom
Copy link
Member

ErikSchierboom commented Mar 2, 2023

Before we merge this, I think we should also add go.mod to the files.invalidator of the exercises

I know you didn't ask me, but: yes! This would be really helpful to students.

@andrerfcsantos andrerfcsantos merged commit 6c89f99 into exercism:main Mar 5, 2023
@andrerfcsantos andrerfcsantos deleted the upgrade-to-go-1.20 branch March 5, 2023 09:41
@andrerfcsantos andrerfcsantos mentioned this pull request Jun 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants