Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to run 1.18 #2374

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Conversation

andrerfcsantos
Copy link
Member

@andrerfcsantos andrerfcsantos commented Jul 18, 2022

Related to #2129

Summary of the changes:

  • Make actions refer Go 1.18
  • Update golangci-lint of the test script to a version that accepts go.mod files referencing go versions < 1.18
  • Copy strings.Title in place in exemplar solutions to bypass a linter check of deprecation (strings.Title is deprecated, and using the alternative is not viable)

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2022

Dear andrerfcsantos

Thank you for contributing to the Go track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ⬆️ The instructions and test cases for many practice exercises originate in the Exercism-wide problem-specifications repo. If the exercise you changed is listed there in the exercises folder, please consider the following.

    • Improvements to the instructions.md file should be made in the problem-spec repo so that all tracks can benefit.
      You can open a PR there instead.
    • If you want to add some language specific information, use the instructions.append.md file (see Practice Exercise Docs).
    • Test cases selected in the .meta/tests.toml file need to be implemented in the <exercise>_test.go file according to the specification in canonical-data.json.
  • 🔗 If your PR fully fixes an issue, please include the text Fixes #issue_no in any line of the PR description. This will make the issue be automatically be closed when the PR is merged. If your PR is related to an existing issue but does not fix it completely, please link the issue anywhere in the description of the PR with #issue_no. You can read more about this in Github: Linking a pull request to an issue

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@andrerfcsantos andrerfcsantos marked this pull request as draft July 18, 2022 08:12
@andrerfcsantos andrerfcsantos marked this pull request as ready for review July 18, 2022 09:16
@andrerfcsantos andrerfcsantos added the x:rep/small Small amount of reputation label Jul 18, 2022
@andrerfcsantos andrerfcsantos merged commit 89c3196 into exercism:main Jul 19, 2022
@andrerfcsantos andrerfcsantos deleted the update-ci-to-1.18 branch July 19, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/small Small amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants