Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed "Output" - Welcome To The Tech Palace (Fixes #2156) #2200

Merged
merged 2 commits into from
Jun 26, 2022

Conversation

TristanAppDev
Copy link
Contributor

@TristanAppDev TristanAppDev commented Apr 22, 2022

Changed "Output" to "=>" - Welcome To The Tech Palace

Related to #2202

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2022

Dear TristanAppDev

Thank you for contributing to the Go track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • 📜 The following files usually contain very similar content.

    • concepts/<concept>/about.md
    • concepts/<concept>/introduction.md
    • exercises/concept/<exercise>/.docs/introduction.md

    Please check whether the changes you made to one of these also need to be applied to the others.

  • 🔗 If your PR fully fixes an issue, please include the text Fixes #issue_no in any line of the PR description. This will make the issue be automatically be closed when the PR is merged. If your PR is related to an existing issue but does not fix it completely, please link the issue anywhere in the description of the PR with #issue_no. You can read more about this in Github: Linking a pull request to an issue

  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@TristanAppDev
Copy link
Contributor Author

This one looks kind of strange to me with the "=>".

AddBorder("Welcome!", 10)
// =>
// **********
// Welcome!
// **********

Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this in this exercise too.

The changes you made are correct. However, this exercise also has code examples in the introduction. The content in that introduction in turn is also present in the introduction.md and about.md of the strings concept.

If it is not much to ask, can you fix the code examples in those files too?

@andrerfcsantos andrerfcsantos added status/awaiting-contributor This pull request is waiting on the contributor. x:rep/small Small amount of reputation labels Apr 25, 2022
@TristanAppDev
Copy link
Contributor Author

Sure, I'll have a look.

@andrerfcsantos andrerfcsantos added x:size/small Small amount of work and removed x:rep/small Small amount of reputation labels Apr 25, 2022
@andrerfcsantos
Copy link
Member

@TristanAppDev Are you still interested in finishing this and #2197? Totally ok if you are no longer interested, just let us know and we can finish it for you :)

@TristanAppDev
Copy link
Contributor Author

I'm still interested. Just have been too busy last weeks.
Sorry for letting you wait.

@andrerfcsantos
Copy link
Member

@TristanAppDev No problem, thanks for letting us know.

Finish when you have the time and if you lose interest that's ok too, just let us know.

Copy link
Member

@andrerfcsantos andrerfcsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There has been some interest from other contributors to fix this issue across the track. Since I had some free time and to make sure this PR is not superseded by another or having someone doing duplicate work, I took the time to finish it so we can merge it!

Thanks again for this contribution.

@andrerfcsantos andrerfcsantos merged commit 44dd70d into exercism:main Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/awaiting-contributor This pull request is waiting on the contributor. x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants