Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make tests use local version of this package #51

Open
kljensen opened this issue Jan 16, 2024 · 1 comment
Open

Make tests use local version of this package #51

kljensen opened this issue Jan 16, 2024 · 1 comment
Labels
help wanted Extra attention is needed x:rep/large Large amount of reputation

Comments

@kljensen
Copy link
Contributor

Notice that the tests in tests using a pinned version of this package, e.g. https://github.com/exercism/gleam-test-runner/blob/52841faf69669bebd90c948a4b79398c36a082d4/tests/all_fail/gleam.toml and 356d594.

The effect is that, when a PR is made in this repo, the CI tests run with the pinned version, not the code in the PR. This seems problematic. Further, the tests in runner are not run in CI I think.

If, as I suspect, this is not desired behavior, I think three fixes are needed.

  1. Make gleam.toml in tests/** use the local exercism_test_runner package by specifying the relative path.
  2. Making the test-in-docker.sh script mount directories such that the local exercism_test_runner is available in docker.
  3. Adding the runner tests to the GitHub Actions CI workflows.

If somebody confirms the above I'm happy to work on it.
@lpil
Copy link
Member

lpil commented Jan 17, 2024

Sounds great! Thank you

@lpil lpil added help wanted Extra attention is needed x:rep/large Large amount of reputation labels Jan 17, 2024
kljensen added a commit to kljensen/gleam-test-runner that referenced this issue Jan 21, 2024
@kljensen
Make tests use local version of exercism_test_runner. Closes exercism#51
f96ccf4 


Previously the tests had a hard-coded version of `exercism_test_runner`.
This is not ideal because the CI tests are not actually testing the
code in the repo---it is instead testing a previous version.

There are a few pieces to this changeset.

1) The `exercism_test_runner` path is made local and relative
in all of the `gleam.toml` files in the `tests` directory.

2) The `gleam_stdlib` versions are updated in those `gleam.toml`
files to be consistent with the version used by the local
`exercism_test_runner`.

3) An extra mount point is added in the Docker command that
runs the tests so that the tests have access to the local
version of `exercism_test_runner`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed x:rep/large Large amount of reputation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kljensen @lpil