Collatz conjecture exercise #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaschaMann
reviewed
Dec 19, 2020
bin/create_fortran_test.py
Outdated
| @@ -119,7 +119,7 @@ def create_test(test_name, json_name): | |||
| j = None | |||
| with open(json_name) as f: | |||
| j = json.load(f) | |||
| exercise_version = j['version'] | |||
| exercise_version = j['version'] if 'version' in j else None | |||
There was a problem hiding this comment.
The JSON files no longer have versions (see exercism/problem-specifications#1674), so this will always be None.
There was a problem hiding this comment.
Thanks, removed version
SaschaMann
approved these changes
Dec 27, 2020
| @@ -0,0 +1,28 @@ | |||
| [canonical-tests] | |||
There was a problem hiding this comment.
This and the tests.toml file below seem unrelated to the PR. Merging probably won't cause any issues, just pointing it out in case they were committed by accident.
| @@ -0,0 +1,35 @@ | |||
|
|
|||
| ! This test was created from E:\nosave\code\gitrepos\pclausen\problem-specifications\exercises\collatz-conjecture\canonical-data.json | |||
There was a problem hiding this comment.
You might want to strip the first part of the path from this comment as it's specific to your computer.
| implicit none | ||
|
|
||
| ! Test 1: zero steps for one | ||
| ! UUID 1: 540a3d51-e7a6-47a5-92a3-4ad1838f0bfd |
There was a problem hiding this comment.
The test UUIDs are mostly meant for track tooling. It's best to not expose them to the students and instead only leave the comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding Collatz conjecture exercise