Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for optional tests for reverse string #646

Merged
merged 3 commits into from
Aug 10, 2024

Conversation

meatball133
Copy link
Member

@meatball133 meatball133 commented May 24, 2024

This pr is dependent on the 2.1 update for the test runner and documentation about tags is also missing.

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@meatball133 meatball133 marked this pull request as ready for review August 7, 2024 08:54
# Instructions append

The Crystal track add optional test to test to test possible letters to be any unicode character, not just ASCII alphabetic ones.
These are not accesaible from the web editor, but is default when exectued locally.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These are not accesaible from the web editor, but is default when exectued locally.
These are not accessible from the web editor, but are run by default when executed locally.

@@ -0,0 +1,6 @@
# Instructions append

The Crystal track add optional test to test to test possible letters to be any unicode character, not just ASCII alphabetic ones.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Crystal track add optional test to test to test possible letters to be any unicode character, not just ASCII alphabetic ones.
An optional test has been added that tests for possible letters to be any unicode character, not just ASCII alphabetic ones.

The Crystal track add optional test to test to test possible letters to be any unicode character, not just ASCII alphabetic ones.
These are not accesaible from the web editor, but is default when exectued locally.

To disable these tests, when calling the test runner, add the following flag: `--tag "~optional"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think students know what a test runner is.

@ryanplusplus ryanplusplus merged commit ed9874a into exercism:main Aug 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants